Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): first time choosing a pipeline definition is VERY slow. Fixes #10897 #11130

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix(frontend): first time choosing a pipeline definition is VERY slow. Fixes #10897 #11130

merged 1 commit into from
Sep 16, 2024

Conversation

ElayAharoni
Copy link
Contributor

@ElayAharoni ElayAharoni commented Aug 22, 2024 •
edited
Loading

Fixes #10897.
i found that whenever a V2 pipeline is chosen for a new run, then there is a check whether v1Template is fetching and because it is not a v1 pipeline then the message is seen for long time.

so basically what i did is check whether the v1 template is fetching only when the pipeline is v1 and not v2, which cause in significant reduce in the loading time.

@google-oss-prow Google OSS Prow
Copy link

Hi @ElayAharoni. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ElayAharoni
Copy link
Contributor Author

/ok-to-test
/rerun-all

@google-oss-prow Google OSS Prow
Copy link

@ElayAharoni: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test
/rerun-all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hbelmiro
Copy link
Contributor

/ok-to-test
/rerun-all

@ElayAharoni
Copy link
Contributor Author

please review when you get the chance.
@HumairAK , @zijianjoy

chensun
chensun approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 16, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit cfb3b31 into kubeflow:master Sep 16, 2024
9 checks passed
@TheKevJames TheKevJames mentioned this pull request Sep 17, 2024
Merged
1 task
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 18, 2024
@ElayAharoni @sefgsefg
fix(frontend): first time choosing a pipeline definition is VERY slow. …
d23963e 
…Fixes kubeflow#10897 (kubeflow#11130)

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Co-authored-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Signed-off-by: sefgsefg <[email protected]>
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 18, 2024
@ElayAharoni @sefgsefg
fix(frontend): first time choosing a pipeline definition is VERY slow. …
a28658f 
…Fixes kubeflow#10897 (kubeflow#11130)

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Co-authored-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Signed-off-by: sefgsefg <[email protected]>
R3hankhan123 pushed a commit to R3hankhan123/pipelines that referenced this pull request Sep 20, 2024
@ElayAharoni @R3hankhan123
fix(frontend): first time choosing a pipeline definition is VERY slow. …
08f785d 
…Fixes kubeflow#10897 (kubeflow#11130)

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Co-authored-by: Elay Aharoni (EXT-Nokia) <[email protected]>
sefgsefg pushed a commit to sefgsefg/pipelines that referenced this pull request Sep 20, 2024
@ElayAharoni @sefgsefg
fix(frontend): first time choosing a pipeline definition is VERY slow. …
e014934 
…Fixes kubeflow#10897 (kubeflow#11130)

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Co-authored-by: Elay Aharoni (EXT-Nokia) <[email protected]>
zed546213 pushed a commit to zed546213/pipelines that referenced this pull request Sep 23, 2024
@ElayAharoni @zed546213
fix(frontend): first time choosing a pipeline definition is VERY slow. …
8e50c10 
…Fixes kubeflow#10897 (kubeflow#11130)

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Co-authored-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Signed-off-by: zed546213 <[email protected]>
chris454656 pushed a commit to chris454656/pipelines that referenced this pull request Sep 24, 2024
@ElayAharoni @chris454656
fix(frontend): first time choosing a pipeline definition is VERY slow. …
4ca3697 
…Fixes kubeflow#10897 (kubeflow#11130)

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Co-authored-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Signed-off-by: chris <[email protected]>
boarder7395 pushed a commit to boarder7395/pipelines that referenced this pull request Oct 17, 2024
@ElayAharoni @boarder7395
fix(frontend): first time choosing a pipeline definition is VERY slow. …
1048eb6 
…Fixes kubeflow#10897 (kubeflow#11130)

Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Co-authored-by: Elay Aharoni (EXT-Nokia) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun approved these changes

@HumairAK HumairAK Awaiting requested review from HumairAK

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[frontend] first time choosing a pipeline definition is VERY slow
3 participants
@ElayAharoni @hbelmiro @chensun